Codecov Report

Attention: Patch coverage is 20.85561% with 148 lines in your changes missing coverage. Please review.

Project coverage is 88.02%. Comparing base (058d793) to head (5d15467).

@@            Coverage Diff             @@
##             main     #713      +/-   ##
==========================================
- Coverage   88.76%   88.02%   -0.74%     
==========================================
  Files          84       85       +1     
  Lines       17890    18077     +187     
  Branches     3483     3528      +45     
==========================================
+ Hits        15880    15913      +33     
- Misses       1640     1792     +152     
- Partials      370      372       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ychiat35 - thank you for adding this worker. Would it be possible to test it within a container?

@ychiat35 - thank you for adding this worker. Would it be possible to test it within a container?

Hi, I'm trying to use oar-docker to do that. It is still WIP (I have to find more time doing that) but I noticed that the oar-docker solution requires cgroup v1, so I have to run on ubuntu-20.04 but not ubuntu-latest. Is this a problem for you?

Did you ever get this working? Should I try to port it to the new structure

Thanks a lot for contributing this @ychiat35 !

The docs failure is an issue I'm running into in all my GH Actions that need MRtrix so should hopefully sort that out with the MRtrix conda pkg maintainers soon.

So the code looks good on a first pass but we need to add some way to install/setup a OAR scheduler the github action so we can test it.

There is also the question of whether this is better maintained in a separate plugin rather in the main code base or not. Do you have any thoughts on this @effigies @djarecka @satra ? I would probably lean towards a separate plugin due to the effort required to setup a test environment for it (like we have proposed for the SGE worker #506). I have created a template repo for such plugins here, https://github.com/nipype/pydra-workers-template

a separate repo makes it easier for long term maintenance or abandonment.

@ychiat35 is it possible to set this up as a separate plugin/repo using the https://github.com/nipype/pydra-workers-template template? If you need a hand with this at all let me know